szagoruyko/nnpack.torch

Typos in pad sizes?

Closed this issue 8 years ago · 1 comments

mikowals commented 8 years ago

{top = padH, bottom = padH, left = padW, right = padH} should have right=padW I think.

https://github.com/szagoruyko/nnpack.torch/blob/master/functional.lua#L16
https://github.com/szagoruyko/nnpack.torch/blob/master/functional.lua#L65
https://github.com/szagoruyko/nnpack.torch/blob/master/functional.lua#L85

szagoruyko commented 8 years ago

fixed via 336731f, thanks