Add an endpoint for refreshing tokens

Question

Add an endpoint for refreshing tokens

szerhusenBC opened this issue 5 years ago · 7 comments

There should be an endpoint to refresh tokens before they expire. You should get a new token. Tokens which are expired should be decline.

Answer 1 · 2020-03-28T09:42:57.000Z

I created the endpoint in a new local branch.

If the current token is expired it returns 401, if not it returns a new token.

I can create a PR for you to review, I think i would need your permission to push ? :-)

Thanks

Jose

Answer 2 · 2020-04-07T19:01:13.000Z

@jmdopereiro Sorry for that late answer! Just create a pull request so that I can review and merge it.

Answer 3 · 2020-04-09T14:37:40.000Z

Hi Stephan, I have created a local branch and committed the changes to it, but when I try to push it (not sure I can create the PR without pushing first my branch) I get a 403.

Answer 4 · 2020-04-09T15:02:21.000Z

Ah, OK. The normal way is to fork this project, create a new branch on your forked project and then create a PR. Could you try that?

Answer 5 · 2020-04-09T15:18:31.000Z

yeap ok, I did it, what do you think ?

Answer 6 · 2020-04-09T19:47:42.000Z

I saw it, looks good so far. One thing, did you check, that I fails, if the token you want to refresh is too old? I can't test it myself right now. It shouldn't be possible to refresh a token, that is too old.

Answer 7 · 2020-04-13T09:40:40.000Z

That's right (sorry I had some troubles with my browser cache). I just retested, decreased the token-validity-in-seconds to 120 and then waited 2 minutes, the new token api is protected as the rest by the JWTFilter so when the current token is expired it doesn't refresh the token but returns 401. Here you have a postman screenshot and the application logs.