Recent changes to introduce variable bash-completion-start-files breaks completion

Question

Recent changes to introduce variable bash-completion-start-files breaks completion

Closed this issue 7 years ago · 6 comments

bash-completion-comm: Symbol’s value as variable is void: startfile1

Answer 1 · 2017-09-09T19:05:53.000Z

I think there are actually two problems, both introduced to the function bash-completion-require-process in commit 21149fd.

One problem is that the name of the dolist loop variable is start-file, but is called startfile1 in the body of the dolist. The second problem is that there is a missing conditional (either if or when) at the start of the body.

I have a PR to fix both, which I'll submit in a moment.

Answer 2 · 2017-09-09T19:19:57.000Z

Okay, PR #22 ready.

Answer 3 · 2017-09-09T19:21:47.000Z

Wow! That was remarkable quick. Thanks!

Answer 4 · 2017-09-11T21:40:42.000Z

You're very welcome; I hope @szermatt gets a chance to merge it soon.

Answer 5 · 2017-09-24T16:02:13.000Z

I merged it last week and it looks fine. Thank you for the fix! Sorry for breaking completion. I'm currently trying to set things up to avoid such issues.

Answer 6 · 2017-09-24T16:05:47.000Z

Thank you. No problem about the "breaking". These things happen, and I think your work to avoid such things in the future is awesome. I saw from the commit history that most of the recent work was to improve the test infrastructure. I really appreciate the emacs module and all your hard work!