fallbackDuration behaviour doesn't match docs
Opened this issue · 1 comments
fallbackDuration
is documented as:
When the DNS server responds with
ENOTFOUND
orENODATA
and the OS reports that the entry is available, it will usedns.lookup(...)
directly for the requested hostnames for the specified amount of time (in seconds).
In reality, it's not a cache time, it's a periodic reset frequency:
cacheable-lookup/source/index.js
Lines 97 to 106 in da10b58
For example, if it's set to 1 hour, and then 55 minutes after creating the CacheableLookup instance a hostname lookup fails, the fallback usage will only be cached for 5 minutes (the time until the next reset).
This isn't a big problem for me particularly right now, just something I noticed.
Good spot! I must've overlooked this. Will fix this ASAP.