t0m/select2-bootstrap-css

Demo page is busted when using https

adamjohnson opened this issue · 3 comments

adamjohnson commented

When visiting the demo page, the CSS & JS don't get loaded because it's requesting the file over http. Relevant lines:

https://github.com/t0m/select2-bootstrap-css/blob/bootstrap3/_jekyll/_includes/head.html#L6

that line should be:

  <link rel="stylesheet" href="//ivaynberg.github.io/select2/select2-{{ page.version }}/select2.css">

and

https://github.com/t0m/select2-bootstrap-css/blob/bootstrap3/_jekyll/index.html#L63-L64

these lines should be:

<script src="//ajax.googleapis.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script>
<script src="//ivaynberg.github.io/select2/select2-3.4.2/select2.js"></script>

Here's what the demo page looks like when using https:

http://cl.ly/WyqK

adamjohnson commented

Looks like this issue is also happening on the Bootstrap v2.x demo page as well:

https://t0m.github.io/select2-bootstrap-css/3.4.1.html

fk commented

Thanks @adamjohnson!
Both demo pages are fixed:

adamjohnson commented

Right on Florian. Nice work! 👍