Bug in pio-instr-relocate-mem!

Question

Bug in pio-instr-relocate-mem!

pkoning2 opened this issue a year ago · 5 comments

pio-instr-relocate-mem relocates the jumps, but it still writes the program starting at PIO offset zero rather than at the supplied offset, which overwrites some other program.
To fix it, the line that writes an instruction should read:
2 pick i + 2 pick INSTR_MEM !

Answer 1 · 2023-12-25T22:32:44.000Z

Thanks for catching this - as you can probably guess, I don't bang on PIO that much.

Answer 2 · 2023-12-25T22:58:36.000Z

I have added your fix to the devel branch and will confirm that it works once I get the chance tonight or tomorrow. Then I will merge it into the other branches and make an (RP2040-ONLY) release containing the change.

Answer 3 · 2023-12-26T03:33:28.000Z

I have made a fix to this, and tested the fix by using the CYW43439 half-duplex SPI PIO program with a different PIO program address other than 0 to blink the LED driven by the CYW43439.

Answer 4 · 2023-12-26T13:56:22.000Z

This fix is in release 1.3.5.1.

Answer 5 · 2023-12-26T20:07:48.000Z

PIO was the original reason for me to start using the Pico, so I use it a lot. Thanks for the quick fix.