Week 3 Project: Simple Twitter Client - Ready for Review
Opened this issue · 1 comments
Here is my third week's assignment, please review. /cc @codepathreview @codepath
Nice work overall. A few notes after checking out the code:
- Good efforts polishing the UI to make the app look twitter branded
- Great job implementing the compose tweet feature as a dialog
- Nice to see you used the
SwipeRefreshLayout
for easy timeline refreshes - Good to see you were able to format the time-stamp cleanly (Consider externalizing the logic to a
Utils
class) - Nice touch with the character count being displayed while the user composes a tweet
- Good to see you refreshed the timeline after composing a new tweet
- Consider adding local persistence of tweets by using ActiveAndroid in the
Tweet
andUser
. See the persistence guide and this other guide for more details. - Nice touch adding
FloatingActionButton
for composing tweet instead ofActionBar
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.