tagnote-app/markdown_viewer

Table are not scrollable

Closed this issue · 9 comments

image

how can i fix the table to make it a scrolllable one because it is being cropped otherwise

Thanks for reporting this issue, I will fix it

thank you

@ari-borlaza Fixed, please update to markdown_viewer: ^0.6.0

Thank you very much! This fixes it!

Don't know if this created the issue but, tables are not 100% width when they don't scroll.

Tables should occupy the whole width area, then scroll. Such as this:

Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column
Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column
Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column
Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column
Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column
Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column
Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column
Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column Very large column

If this is too hard to implement, maybe there should be an extra setting for us to tell the render if we want or not a scrolling table.

@JCKodel maybe we should have an extra setting to force the tables to occupy the whole width, what do you think?

I think: if you want a table, then build a Table widget =)

Markdown should be simple, and the scroll should be the exception.

The table is a Table widget:

https://github.com/tagnote-app/markdown_viewer/blob/master/lib/src/builders/table_bilder.dart#L104

I know =)

What I meant was: if one needs a real Table with scroll and everything, they should go for a Table widget, not trying to make it on markdown =) Because it's so easy to do a Column > Markdown > Table > Markdown.

I'll probably use this widget a lot in some projects I'm working. If this is the case, I'll try to help with PR instead of just issues.