tailscale/terraform-provider-tailscale

Add name field to acl rules

markwellis opened this issue · 1 comments

Is your feature request related to a problem? Please describe.
I use terraform to add additional ACL rules by merging with the existing rules. Without a way of naming them there's no way to remove these rules automatically whilst preserving existing rules.

E.g.
If I have this array in terraform of acl rules that I will merge with the existing rules via a distinct(merge(old_rules, new_rules))

[
  {
    "action": "accept",
    "src": [
      "tag:foo"
    ],
    "dst": [
      "*:*"
    ]
  },
  {
    "action": "accept",
    "src": [
      "tag:bar"
    ],
    "dst": [
      "*:*"
    ]
  },
]

Some time later, I want to remove the second rule (src: tag:bar) from the acls, I can't just remove it from that array I have to do it manually in the tailscale admin interface.

If there was a name field I could name the rules with a prefix, e.g. tf-added-rule- and I could delete all the rules with that name prefix from old_rules before doing the merge(old_rules, new_rules)

Describe the solution you'd like
Add a name field to acl rules. This should be unique among the rules.