False alarm of deprecation.

Question

False alarm of deprecation.

Closed this issue 8 years ago · 17 comments

I've replaced react-router with rrtr, both are most recently version, and I got this warning without any code changes:

Warning: [react-router]props.historyandcontext.historyare deprecated. Please usecontext.router. http://tiny.cc/router-contextchanges

A demo repo can be provided later if you need it.

Answer 1 · 2016-04-13T15:08:07.000Z

Crud, this is probably #15. Do you have a stack trace associated with the warning? How is it getting invoked?

Answer 2 · 2016-04-13T15:29:33.000Z

Ye, I think so with #15, here is stack trace:

Warning: [react-router] `props.history` and `context.history` are deprecated. Please use `context.router`. http://tiny.cc/router-contextchangeswarning @ browser.js:49
  routerWarning @ routerWarning.js:31
  get @ deprecateObjectProperties.js:23
  dehydrate @ backend.js:1685
  dehydrate @ backend.js:1685
  dehydrate @ backend.js:1685(anonymous function) @ 
  backend.js:917flush @ 
  backend.js:912(anonymous function) @ 
  backend.js:900

And I just publish a demo at https://github.com/very-geek/univera

Just uncomment https://github.com/very-geek/univera/blob/develop/config%2Fwebpack.babel.js#L33 to reproduce this warning (I temporarily use react-router as a fallback).

Answer 3 · 2016-04-13T15:55:02.000Z

What specifically would I need to run/do to see that warning?

Answer 4 · 2016-04-13T15:57:01.000Z

And which browser, too, sorry.

Answer 5 · 2016-04-13T15:57:22.000Z

clone https://github.com/very-geek/univera
npm install
npm start && open localhost:3000
uncomment Line 33 in config/webpack.babel.js to use rrtr instead of react-router

then you would see it.

Answer 6 · 2016-04-13T15:57:52.000Z

I use chrome dev channel and safari.

Answer 7 · 2016-04-13T15:58:15.000Z

One last question – which version of the React dev tools are you using?

Answer 8 · 2016-04-13T15:59:32.000Z

v0.14.9, I believe the most recent version from chrome store

Answer 9 · 2016-04-13T16:06:51.000Z

I'm sorry, one final question for real – can you confirm the specific version of Chrome you're on? Is it 51.0.2700.0 dev?

Answer 10 · 2016-04-13T16:08:13.000Z

it's ok, my bad, it is version 50.0.2657.0 dev (64-bit)

Answer 11 · 2016-04-13T16:08:33.000Z

That's very helpful. Thanks, give me a bit to get this properly reproduced.

Answer 12 · 2016-04-13T16:09:36.000Z

Thank you, I guess we need an issue template as well 😸

Answer 13 · 2016-04-13T16:11:13.000Z

This is a bit of a special case. I'm using an advanced feature of proxies, which is apparently only partially supported in Chrome < 51, and only comes up with the dev tools. I don't think this usually comes up, and anyway I was trying to be too clever by half.

Answer 14 · 2016-04-13T16:13:23.000Z

Ah I see, let me try on Chrome 51 dev to see what's coming up.

Answer 15 · 2016-04-13T16:14:01.000Z

It shouldn't, given that I'm not seeing it, but I'm going to revert the change to the deprecation wrapper anyway, since breaking users on the beta and stable channels of Chrome is not really what I want to do.

Answer 16 · 2016-04-13T16:16:38.000Z

Yay, that's nice, I'm sick of tweaking here and there on react-router for a long time, really hope rrtr will be the one does everything right, thanks for all your efforts!

Answer 17 · 2016-04-13T16:36:14.000Z

Fixed on 2.2.1.