tair-opensource/TairHash

rdb save may sometimes cause downtime

631086083 opened this issue · 4 comments

631086083 commented

Hello, during the process of using tairHash, when saving the RDB, I found that an error occurred. Through the debug source code, I found that some functions do not exist in the header file of the redis module.
In the redis official website code, I found that you are in Redis submitted No. 8999 on June 16. If a function lower than this version is used, the redis instance will be down.

ps: I developed a simple client in python language, which is compatible with tairHash commands. If you have time, please help me and take a look. https://github.com/631086083/tairClient

yangbodong22011 commented

Hello, during the process of using tairHash, when saving the RDB, I found that an error occurred. Through the debug source code, I found that some functions do not exist in the header file of the redis module.
In the redis official website code, I found that you are in Redis submitted No. 8999 on June 16. If a function lower than this version is used, the redis instance will be down.

yes, we have a notice here.

ps: I developed a simple client in python language, which is compatible with tairHash commands. If you have time, please help me and take a look. https://github.com/631086083/tairClient

Thank you for your contribution!
Before adding it to the TairHash README list, I have some suggestions:

  • add some tests
  • the result of api can be map or list etc.. instead of the result of execute_command, you can refer: alibabacloud-tairjedis-sdk
  • rename tairClient to tair-py (Up to you, not necessary)
chenyang8094 commented

when saving the RD

Thank you for your interest in tairhash. Currently, tairhash implements a more efficient active expire at the cost of the need for new module api support, which makes tairhash unable to be used on lower versions of redis. We also recognize this and are thinking about whether we can solve this problem by some means, such as adding a macro compilation option to make tairhash can run in lower versions redis. Of course, this will definitely discount some features. At the same time, if you have any ideas, welcome to communicate with us or submit PR.

Finally, thank you for your python client for tairhash, it is an amazing project:）.

  • 😄1
631086083 commented

sorry， it‘s my problem, my English is relatively bad, I translated that sentence into a version that needs to use redis4 or higher...
——————
Thank you very much for your suggestions, this python client does have a lot of improvements at present:

some test cases will be added to the tests in the future (including the overall module test, and the unit test of the command);
in the callback value part, by adding the callback function to analyze the return value to deal with different return methods
add more module command support and documentation

chenyang8094 commented

Hello, during the process of using tairHash, when saving the RDB, I found that an error occurred. Through the debug source code, I found that some functions do not exist in the header file of the redis module.
In the redis official website code, I found that you are in Redis submitted No. 8999 on June 16. If a function lower than this version is used, the redis instance will be down.

ps: I developed a simple client in python language, which is compatible with tairHash commands. If you have time, please help me and take a look. https://github.com/631086083/tairClient

Hi guys, we have recently merged a new PR, which allows TairHash to run in low version redis ( redis 5.x and redis 6.x), which may be of interest to you.

  • 👍2