tajo/react-portal

using `mouseup` for closeOnOutsideClick behaviour is troublesome

mateomurphy opened this issue · 3 comments

mateomurphy commented

Using mouseup means that clicking inside the modal, dragging out, and releasing closes the modal. This is a pretty common occurrence using modals for forms.

I understand that mouseup was used to solve #65 , was using click not an option?

mufasa71 commented

Any updates on this?

mateomurphy commented

Hi, I'm sorry I didn't get a notification for your commit, I will test it out this week!

  • 👍1
tajo commented

Hey, please check the new major version of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

I am happy to discuss this with v4 in mind.