talent-plan/tinysql

There may be a bug in checkColumnAttributes

SenZhangAI opened this issue · 1 comments

https://github.com/pingcap-incubator/tinysql/blob/17211e65f907ffb7deb437a722485440682845d6/ddl/ddl_api.go#L647-L660

code here is a little strange, why mysql.TypeDatetime, mysql.TypeDuration, mysql.TypeTimestamp need to check precision?

Perhaps this is for case mysql.TypeNewDecimal, mysql.TypeDouble, mysql.TypeFloat

I found original code here

pingcap/tidb#7294

It's ok