talkpython/100daysofcode-with-python-course

Possible misleading typo in 22-24 Decorators

Closed this issue · 1 comments

In 100daysofcode-with-python-course/days/22-24-decorators/decorators.ipynb under "Second day: a practical exercise" you list the following block of code:

@make_html('p')
@make_html('strong')
def get_text(text):
    pass

As the problem is listed now it implies that make_html decorator should be responsible for printing the test instead of just adding tags. In the linked pybite get_text() is defined as:

def get_text(text):
    print(text)

Is that pass in the jupyter notebook a typo, which instead should be print(text)?

Hey @benkawecki I agree, print(text) would be better/clearer. I updated the notebook. Thanks.