Remove use of `mode: all`

Question

Remove use of `mode: all`

Closed this issue a year ago · 5 comments

Do we want to stop using mode: all? It seems like it could be surprising if a user creates a mode and unexpected commands are active

See also #603

Answer 1 · 2023-02-28T20:54:36.000Z

I'd be fine with removing all the invocations in the repository but leaving the mode itself in case users want to use it in their own forks (it can be handy if you don't plan to make additional modes)

Answer 2 · 2023-03-01T20:42:59.000Z

wait, all is a mode? I thought mode: all was a special thing

Answer 3 · 2023-03-04T17:49:24.000Z

all is "sort of" a mode in that it's present in scope.get("mode"). But it's always active and cannot be disabled, so it's not a mode the user can activate/deactivate.

Answer 4 · 2023-03-04T17:52:40.000Z

counterpoint: folks may want go to sleep to be active in all modes.

Answer 5 · 2023-04-29T15:50:15.000Z

We talked about this on the maintenance session today.

We were generally in agreement that removing "mode: all" and "not mode" from all files makes sense
Andreas felt that it makes sense to have a separate Talon file for each mode
We could consider a configurable "what happens when I wake up or sleep Talon" rather than separate commands, then each command implementation would be a single line of TalonScript (e.g., the ones that hide various elements of the knausj help system)
Or at the least we should comment the difference between "welcome back" and "Talon wake", etc.