Fix all existing context matching to be consistent across the repo
Opened this issue · 1 comments
I got confused while doing a review yesterday on #1401 because I happened to be looking at https://github.com/talonhub/community/blob/main/core/application_matches.py around the same time and we are constantly using and where I guess we don't need to. I think almost (not all) of those are redundant?
Also just quickly poking around elsewhere, eg https://github.com/talonhub/community/blob/main/apps/outlook/outlook_win.talon, we are using and where it isn't needed.
Probably makes sense to fix all these to not have superfluous logic, where https://talon.wiki/customization/talon-files/ is probably the best reference of the AND and OR behavior.
If I'm derping here still, I'm happy to be corrected :D
This sounds right, though we should fix the associated helpers. Probably the culprit for most of these :)