serde_qs
nicrosengren opened this issue · 4 comments
I cant upgrade aide and therefor not axum since I have to have duplicate versions of axum because of aides dependency on serde_qs.
I noticed a PR for serde_qs was opened in december.
The repo has quite a few open issues and no activity since march of last year so the PR might be left hanging for a while.
Would it be an idea to maybe move serde_qs to it's own feature flag since it's not a default dependency of axum? Enabling the query feature in axum uses serde_urlencoded which is sufficient for most users.
Sad letting an inactive, optional, dependency drag this project down.
I'm happy to help with this, I just thought I ask before implementing anything.
Yes, i did that PR, you can use it by adding this after the dependencies:
[patch.crates-io]
serde_qs = { git = "https://github.com/Wicpar/serde_qs.git" }
if you want to manually make a type compatible you may want to look at WithApi
and make a type alias.
Yes, that's a good way of doing it today.
My question was summing up to wether or not hiding serde_qs behind a feature instead of including it in the axum feature would be something you might consider?
Especially since axum does not depend on serde_qs.
It is already behind the serde_qs feature
Ahh, I see. I was not completely read up on rust feature flags. Thanks for your replies and help!