Consider removing derive_more dependency

Question

Consider removing derive_more dependency

svix-jplatte opened this issue 6 months ago · 2 comments

This dependency is only used to derive trivial implementations of AsRef, AsMut, Deref, DerefMut and From, but it comes with a pretty significant compile time hit (3.3s on my machine, compared to aide's 4.6s). Would you accept a PR to replace those derived implementations with hand-written ones (or maybe macro_rules!-generated ones)?

Answer 1 · 2024-03-06T12:27:49.000Z

oh i didn't know it had such an impact... hand written ones are fine, but is there no similar crate with better compile times ? Initially the idea was to remove code bloat from trivial impls.

Answer 2 · 2024-03-06T12:46:28.000Z

I'm not aware of a similar crate with better compile times. But I also expect the hand-written impls to take no more than 100 LOC. I can also try the macro_rules! approach, it should reduce the boilerplate to almost the same extent as using derives.