tanem/react-nprogress

Should isFinished be true on boot?

emulienfou opened this issue · 3 comments

emulienfou commented

Here is a sandbox using next.js, material-ui and React hooks where the issue occurred.
On first page load, isFinished is never set to true, however when you are starting to navigate it works perfectly.

https://codesandbox.io/s/jolly-mountain-pqn2u

tanem commented

Hey @emulienfou, thanks for the repro.

Yea, just looking at the source code again I think it makes sense for isFinished to be set to true when everything boots up.

I'll make a change and will let you know when it's ready.

  • 👍1
tanem commented

Have included the changes in version 3.0.48 which was released a short time ago. Looks like the example you provided isn't behaving how I'd expect though, even with these latest changes, so I'll double-check things ASAP.

tanem commented

Hey @emulienfou, this should be fixed now. Seemed to be some sort of caching issue in your CodeSandbox example, once I'd meddled with a few things it started picking up the isFinished change that was made in v3.0.48.

I'll go ahead and close the issue now, but feel free to comment if you still need help with anything 🙏

  • 🎉1