tango-controls/cppTango

Gitlab Migration: Please log into GL with your GH account ASAP

Closed this issue · 30 comments

bourtemb commented

Dear cppTango participant (via commits, comments on issue or pull requests, issue creator),

If you have contributed in any way (commit, issue or Pull Request creation or comment) to cppTango, please log into Gitlab.com using your Github account ASAP.
See tango-controls/TangoTickets#47 for details.

For convenience, here is the list of contributors we could already find:

Please tick the box corresponding to your account above when you've already done the login to Gitlab.com using your Github account.
If you are not allowed to tick this box, please simply comment this issue once you've login to gitlab.com using your Github account.

Please note that login on gitlab.com using your Github account is safe and doesn't give your Github password to Gitlab.

Thanks for your cooperation.

asenchenko commented

Done.

  • 👍1
beenje commented

I have the same username on GH and GL (@beenje) and I checked that all the e-mails I used on GitHub are linked to my GitLab account as well.

abogani commented

I have done.

  • 👍1
bourtemb commented

I have the same username on GH and GL (@beenje) and I checked that all the e-mails I used on GitHub are linked to my GitLab account as well.

Thanks @beenje. As far as I understood, if you don't use (at least once) the Github button on gitlab.com to login, you need to ensure your e-mail primary address on Github is also PUBLIC. If it's not the case, the migration tool might not be able to match your commits and comments.
See https://docs.gitlab.com/ee/user/project/import/github.html

When issues and pull requests are being imported, the importer attempts to find their GitHub authors and assignees in the database of the GitLab instance (note that pull requests are called “merge requests” in GitLab).
For this association to succeed, each GitHub author and assignee in the repository must meet one of the following conditions prior to the import:
Have previously logged in to a GitLab account using the GitHub icon.
Have a GitHub account with a publicly visible primary email address on their profile that matches their GitLab account’s email address.

beenje commented

Thanks @bourtemb. I had missed that my public email was not set in GH. It's now updated.

  • 👍1
andygotz commented

I could not login with github the first time. So I logged in to gitlab with my email, then connected my GL account to GH in my profile. After that I could log into GL with GH. I don't know if others encountered this problem.

  • 👍1
jkotan commented

I have done.

  • 👍1
Ingvord commented

+1

  • 👍1
gscalam commented

Done

  • 👍1
cmft commented

Done

  • 👍1
claudio-scafuri commented
  • 👍1
mkomel commented

Done

  • 👍1
josefcibulka commented

Done

  • 👍1
picca commented

Done (I hope :)

  • 👍1
ltjax commented

Done

  • 👍1
tjuerges commented

Done.
Note: I did the same that Andy did.

  • 👍1
HEnquist commented
  • 👍1
delleceste commented

+1

  • 👍1
aureocarneiro commented

Done!

  • 👍1
alexElettra commented

Done, thanks.

  • 👍1
sergirubio commented

done

  • 👍1
bourtemb commented

Gentle reminder, if your Github account name is listed below, please sign in on Gitlab.com using the sign in with Github button.
If you already have a Gitlab account, you should link your account with your Github account, go to https://gitlab.com/-/profile/account and click on connect to GitHub.
Please add your Github account name in the following Framapad when it is done: https://mensuel.framapad.org/p/migration_ready_2548763689

Here are the accounts who haven't done it yet (or didn't report yet that they had done it):

HFRibeiro commented
  • 👍1
bourtemb commented

@HFRibeiro , thank you very much for your comment.
Having an account on Gitlab.com is not enough for the migration to go fully smoothly.
@cpascual did a first migration test 1 month ago with cppTango.
In your case, we can see that the issue you created on github was not perfectly re-created as created by your Gitlab user:
https://gitlab.com/tango-controls/test_gh_import/cppTango/-/issues/660.
The migrated issue does not look too bad but still, could be better if it was created as if your gitlab.com user would have created it.

So, it is important to associate the gitlab.com account with the github.com account (go to https://gitlab.com/-/profile/account and click on connect to GitHub) and I guess most of the SKA developers didn't have to do that up to now.

HFRibeiro commented
bourtemb commented

The cppTango gitlab migration is foreseen on Thursday 21st January 2021.
So if you're mentioned above, please associate your Gitlab account to your GitHub account before that date or connect on Gitlab.com using the GitHub sign in button before that date.
Thanks in advance.

liujin001 commented

Done, maybe too late

  • 👍1
elkinvg commented

Gentle reminder, if your Github account name is listed below, please sign in on Gitlab.com using the sign in with Github button.
If you already have a Gitlab account, you should link your account with your Github account, go to https://gitlab.com/-/profile/account and click on connect to GitHub.
Please add your Github account name in the following Framapad when it is done: https://mensuel.framapad.org/p/migration_ready_2548763689

Here are the accounts who haven't done it yet (or didn't report yet that they had done it):

Sorry.
I added earlier and wrote my Github account name in Framapad

  • 👍1
jairomoldes commented

I already did this on 18-01 and reported to framedata, but I am still listed as not yet done.

  • 👍1
bourtemb commented

I did a import test to Gitlab this morning.
The result can be seen there: https://gitlab.com/tango-controls/test_gh_import/preview-import/cppTango

What is interesting is to see this issue after the migration: https://gitlab.com/tango-controls/test_gh_import/preview-import/cppTango/-/issues/819

Then, we can see all the accounts which have been correctly recognized, and the others.
So, as of today, the following Github accounts have not been recognized correctly on Gitlab:

@cmft and @guifrecuni , could you please check again because you said you followed the instructions but you're still not recognized on Gitlab.
Please read carefully the instructions on tango-controls/TangoTickets#47
If you already have a github account, it is important to associate the gitlab.com account with the github.com account (you should go to https://gitlab.com/-/profile/account and click on connect to GitHub).