play2:dist
Closed this issue · 3 comments
GoogleCodeExporter commented
What steps will reproduce the problem?
1. execute play2:dist
What is the expected output? What do you see instead?
when running play2:dist the jar of the current project is not included in the
archive. I would have expected this be there, we have fixed by specifying a
dependency to self in a mvn profile when calling the play2:dist.
see profile:
<profiles>
<profile>
<id>play2-dist</id>
<dependencies>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>${project.artifactId}</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
</profile>
</profiles>
This happens in the example projects too - well at least this one: 'comet-clock'
What version of the product are you using? On what operating system?
1.0.0-alpha2 - macos / centos / fedora / ubuntu
Please provide any additional information below.
Original issue reported on code.google.com by al...@cakesolutions.net
on 6 Nov 2013 at 2:45
- Merged into: #8
GoogleCodeExporter commented
Your solution is very ugly hack. I don't know why it does not work for you.
I tried on:
https://play2-maven-plugin.googlecode.com/svn/tags/test-projects-1.0.0-alpha2/sc
ala/comet-clock
and latest released version
https://play2-maven-plugin.googlecode.com/svn/tags/test-projects-1.0.0-alpha5/sc
ala/comet-clock
In both cases it works.
Can you execute "mvn clean package play2:dist -X > dist.log" and attach log
here (or send me directly if you don't want to publish it for any reason)? Run
it without your "play2-dist" profile of course.
Original comment by gslowiko...@gmail.com
on 6 Nov 2013 at 10:05
GoogleCodeExporter commented
hello,
I understand the temp solution is a Hack, hence me raising an issue! I have
double checked play2:dist output again and there is definitely and issue. The
plugin DOES create the "self" jar and include it in the "lib" directory.
Although this lib is not included in the start script classpath variable.
Downloading the comet-clock app doing a "mvn package" & "mvn play2:dist"
produces an archive, if you unzip and run the "start" script an error is thrown
saying unable to find application.conf. This is due to the fact the
comet-clock.jar is not on the classpath.
After some digging in the codebase i see you have already fixed this last month
:).
In version alpha2 in AbstractPlay2DistMojo the create the classpath entry in
the start script you only iterate over the filteredArtifacts so the self jar is
not included, hence the problem i was seeing above, this was fixed on Oct 21,
2013. Hence version 5 working for you, i cant imagine version 2 of the demo
worked, but anyways I will just upgrade to the latest version of the pluggin
which will fix my issue meaning i can bin off the mvn profile fudge!
Thanks again for a great plugin.
keep up the good work!
Alex.
Original comment by al...@cakesolutions.net
on 8 Nov 2013 at 12:17
GoogleCodeExporter commented
Original comment by gslowiko...@gmail.com
on 21 Nov 2013 at 11:38
- Changed state: Duplicate