Feedback
roblourens opened this issue · 0 comments
roblourens commented
raw
is assigned 3 times here, you shouldn't need to assign a value to the first one.
https://github.com/tanhakabir/vscode-notebooks-demo/blob/28bcdd388c0ccaf031191493e9bfcb218bdea5d9/src/extension/notebookContentSerializer.ts#L33-L38- And similar for
groceryList
below. Not a big deal just noticeable since you are editing these lines in the demo - Would be cleaner to use
.split()
on the string, your keyword will be the first piece
https://github.com/tanhakabir/vscode-notebooks-demo/blob/complete/src/extension/notebookExecutionKernel.ts#L76 - Omit
fileNamePatterns
from your language in package.json - Avoid using the
-webkit
prefix in your CSS if you can. I think there was a warning for one property.