tannercollin/standardnotes-fs

Split config and cache

weilbith opened this issue · 4 comments

weilbith commented

Hey
First off all thank you for this nice tool!
But I wonder if it would be possible to store the generated keys into a separated file from the config. Usually keys should go into $XDG_CACHE_DIR or similar. Thereby I can integrate my standardnotes-fs configuration (user name and URL) into my dotfile repository and/or manager, without having to worry about security issues.
Do you think this is a possible feature to integrate? I would offer to implement it myself and open a PR in case you don't have time.

tannercollin commented

This is a great idea!

I'll code this up shortly and use whatever appdirs.user_cache_dir returns.

  • 👍1
tannercollin commented

Implemented in f936379! Can you please back your notes up and test?

  • 🎉1
weilbith commented

Works like charm. Nice work! 👍

One note:
If I delete the cache directory, I get asked for my username again, even if this information is still in the existing configuration file. To be optimal this prompt could be skipped and only the password is required to create a new key. But that is nitpicking. 😬

weilbith commented

I would say you can close the issue if you leave it as it is or after implementing this small fix. 🤷‍♂️
Thanks for your help!