tantaman/strut

docker wont build and other problems

Opened this issue · 1 comments

nub3 commented

I tried cloning the repo anonymously (i do have a github account, but my keys not linked to it) and build it with docker. However I ran into a bunch of problems outlined below.

when cloning the repo via http eg

git clone --recurse-submodules http://github.com/tantaman/strut.git

somewhere below an error showed up:

...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:vlcn-io/model.git' into submodule path '/path/to/repo/deps/model' failed
Failed to clone 'deps/model' a second time, aborting

this could be fixed, by changing the .git/config from git@github to a https path

However, after successfully cloning including the suvmodules, I wanted to build the docker image and got the following error:

...
#0 21.30 @vlcn.io/model:build: > @vlcn.io/model@0.1.0 build /app/deps/model/ts/packages/model
#0 21.30 @vlcn.io/model:build: > tsc --build
#0 21.30 @vlcn.io/model:build: 
#0 26.51 
#0 26.51  Tasks:    6 successful, 6 total
#0 26.51 Cached:    0 cached, 6 total
#0 26.51   Time:    24.836s 
#0 26.51 
#0 41.96 src/components/editor/OperatingTableSlide.tsx(31,10): error TS6133: 'selectionBox' is declared but its value is never read.
#0 41.97 src/components/editor/markdown/TextEditor.tsx(12,3): error TS6133: 'useLayoutEffect' is declared but its value is never read.
#0 41.97 src/domain/queries.ts(13,3): error TS6133: 'AnyComponent' is declared but its value is never read.
#0 42.12  ELIFECYCLE  Command failed with exit code 2.
------
ERROR: failed to solve: failed to solve with frontend dockerfile.v0: failed to build LLB: executor failed running [/bin/sh -c pnpm run build]: runc did not terminate sucessfully

Knowing this is a WIP, the following would be a 'nice to have':

  1. mark a branch knowing to build in docker as stable or something else better distinguishable from master
  2. doublecheck if cloning works anonymously
  3. build the docker with a fresh anonymously cloned repo to doublecheck if it works as advertised
tantaman commented

I'll add a CI setup to build the docker file.

I've moved development to the dev branch and main is now the stable branch.

Also, if you're doing development on it I'd recommend just using npm install && npm build && npm dev rather than the docker file.

  • 👍1