tarmstrong/nbdiff

nbmerge save broken in IPython 2.0

Opened this issue · 1 comments

When you save a merged notebook, the PUT request gets a 404 error. This is because IPython.notebook.notebook_name is undefined when the save code runs. We get the following error in Notebook.get_notebook_name():

Uncaught TypeError: Cannot read property 'length' of undefined

This causes the PUT to be made to the following URI:

"PUT /api/notebooks/undefined HTTP/1.1" 404 -

When the notebook object is being created, it has its notebook_name set, which makes this more confusing.

Shouldn't this issue be closed? Also can you upload 1.0.4 to pypi?