tasdikrahman/vocabulary

timeouts

blissend opened this issue · 2 comments

blissend commented

How are they dealt with?

Looking at

vocabulary/vocabulary/vocabulary.py

Line 89 in 9d8870c

response = requests.get(url)
for example doesn't show any setting for it. Would it be possible to add one considering http://docs.python-requests.org/en/master/user/quickstart/#timeouts states it could hang indefinitely?

tasdikrahman commented

How are they dealt with?

As of now, they are not being dealt with. But it's definitely a good to have feature for more robustness.

Would it be possible to add one considering

I would love for contributions from others :)

blissend commented

I would love for contributions from others :)

I thought about it but I prefer using a class configurable variable (self) which would go against the design in place (staticmethods). :(