Make Credentials menu collapse on select
Closed this issue · 6 comments
In theory, react-bootstrap supports this now but in practice, it doesn't seem to work.
You can see the issue by selecting one of the "Sign In" options on the "Sign In" menu. A new window opens, but if you go back to the original window, there's the menu still hanging out, open.
P.S. don't work on this until http://bugzil.la/1395358 is closed.
hello, i would love to work on this issue. Any suggestions on the best way to go about it?
@bessii hello! To fix this, each of the menu items here needs to close the menu before doing their action:
@yash-iiith it looks like @bessii is already tackling this -- it's usually polite to ask before jumping into a task that someone else is already working on.
That said, it's hard to guide you on what might not work with that approach without seeing the code. Can you post a PR?
@djmitche I apologise for jumping into it.
Moved to https://bugzilla.mozilla.org/show_bug.cgi?id=1442937. @bessii are you still working on this?