Add sidebar to Ember example
Closed this issue · 8 comments
Some newer examples did have a missing sidebar, which most of them were added back in this pr: #2254
Could we bring back the sidebar for the Ember example as well?
https://todomvc.com/examples/emberjs/todomvc/dist/
@NullVoxPopuli - is this something that you might be interested in adding? 😄
what's the sidebar look like? does it have markup requirements?
An example can be found here: https://todomvc.com/examples/knockoutjs/
It's part of the todomvc.com website and just gets injected in your build.
It just shows up if you run the todomvc.com website locally, and won't affect the todomvc build.
couple steps needed:
- npm install todomvc-common
- inject the css somewhere:
- inject the js file somewhere: <script src="node_modules/todomvc-common/base.js"></script>
- update this file as needed: https://github.com/tastejs/todomvc/blob/master/learn.json
To preview, you'd need to run the todomvc website from the root.
That's pretty much it. Happy to help / review prs.
This would be super helpful 😄
Hi flashdesignory,this issue is still open . I'm happy to contibute if this still open .
I'll refer to @NullVoxPopuli, if offloading is desired 😄
oh sorry, yes I keep forgetting about this work -- @SparshMadaan if you want to PR -- I'm more than happy to review!
@NullVoxPopuli I'm beginner in open source and I do some little development project of react js can you please let me know how to run this code in my local machine beacause npm start is not working because I made the changes but not able to see . how can i test this code . just give me an idea please
Do you have errors anywhere?
Might be better to hop in to the ember discord https://discord.gg/emberjs
@NullVoxPopuli Thanks Buddy !