taylornetwork/laravel-username-generator

Unique possibly fails

itssamtaylor opened this issue · 1 comments

Possible bug where "unique" values end up not being unique if too short and we do the random pad.

This will only happen if:

  • Too short action is to pad with random digits
  • There is an after unique hook that causes the make unique to not catch the duplicate entry since it won't check ahead

Solution:

  • Run make unique again after everything
    OR
  • Only run it again if the username was too short
    OR
  • Restrict after make unique hook (don't really want to do that)

This seems to not actually be the issue I thought. The make unique will identify similar beforehand. It does however mark something as not unique if similar things exist. Closing.