Attributes are missing quotes around them
cbahiana opened this issue · 2 comments
Hi tbela99
I decided to give a go with GZIP at https://www.pwabuilder.com/, which I had used before for another project.
Firstly the manifest file was not recognized. As I knew there had been a similar issue before I opened a new issue on this.
There had actually been a problem with manifest parsing, but regardless of that, I also received an informing feed back:
Notice that all the attributes are missing quotes around them. In particular, you have this line:
<link href=/manifest59f9eb28b0efc01bfce6b9b41877cb9d2322f142.json rel=manifest>
It should be changed to:
<link href="/manifest59f9eb28b0efc01bfce6b9b41877cb9d2322f142.json" rel="manifest">
Now the manifest is being recognized, but not in its entirety. Options that were filled in the plugin are still not recognized (attachment).
unquoted attributes are perfectly valid with HTML5 https://dev.w3.org/html5/spec-LC/syntax.html#unquoted
If you want to check the manifest attributes, you can use your browser console. In this screenshot, I used firefox on github
You should note that I may have not implemented support for all attributes because new attributes are added to the specs from time to time. The majority of the attributes listed in your screenshot are supported
quotes are removed when you enable HTML minification and the page uses HTML5. Feel free to reopen this issue if you still have questions