tbrand/neph

Fail to compile on crystal 0.25

Closed this issue · 8 comments

waghanza commented

Hi,

neph fails to compile on last crystal.

crystal 0.25.0 has been released 4 days ago and removed YAML::Type.

Regards,

tbrand commented

Good catch! I believe #50 contains the fixes as well.

waghanza commented

👍 but if a release could be made with this it could help me work on https://github.com/tbrand/which_is_the_fastest 😜

@tbrand At least, I can downgrade crystal

tbrand commented

Oh I see...
Could you delay the release for days?:pray:
I think @notramo will release soon.

How does it sounds @notramo?

waghanza commented

@tbrand not a problem for me 😛 as I can downgrade on my distribution, however the more important will be when CI will update the crystal image

tbrand commented

Thanks!

notramo commented

@waghanza @tbrand
I've waited for crystal 0.25 to be available in the Arch Linux repos.
Maybe it could be released earlier before the CI output mode is implemented.
Unfortunately, the new branch also uses YAML::Type.
Crystal 0.25 has also YAML::Type.
The change is that e.g. YAML::Any#to_a returns an Array(YAML::Any) instead of Array(YAML::Type).
If somebody want to help porting to Crystal 0.25, the changes needed are mostly replacing YAML::Type with YAML::Any in some places, and invoking #to_s, #to_a, #to_h etc. when accessing Array or Hash items.

notramo commented

@waghanza @tbrand Please don't close issues until they are solved. Downgrading Crystal is only a temporary workaround.

notramo commented

@tbrand @waghanza
I updated the source code to Crystal 0.25. It was easier than I thought, and the new API of the YAML deserializer is much better.
You can try it. Just check out the config_redesign branch. Also, see #63