Enhance the build

Question

Enhance the build

kltan opened this issue 8 years ago · 8 comments

I am thinking that the /dist folder should be added to .gitignore to reduce the diff noise and /lib is added to .npmignore. During prepublish we add the build script so that it's published to npm.

"prepublish": "npm run build && babel lib --source-maps -d dist/cjs"

Answer 1 · 2016-08-30T21:56:13.000Z

@tbranyen If proposal is accepted I can open up a PR.

Answer 2 · 2016-08-30T21:57:30.000Z

@kltan I've used the approach you're describing in quite a few of my other open source projects. The reason why I've stopped doing this for diffHTML and others, is that there is just too much utility in being able to point to a SHA and be able to test immediately.

I have a .gitattributes file added that will silence any dist files from showing up in local diffs, I really wish @github would support this as well.

Answer 3 · 2016-08-30T21:58:12.000Z

Also if you ignore lib you're going to make life a lot harder for those who want to use the actual ES6 source.

Answer 4 · 2016-08-30T22:04:30.000Z

@tbranyen Ah, makes sense, although it's still a pain in GitHub.

Answer 5 · 2016-08-30T22:05:16.000Z

I totally agree, I really wish it could be nicer. My suggestion would be not to commit the dist files until you're ready to merge/test (if you want better looking diffs).

Answer 6 · 2016-08-30T22:05:35.000Z

Lets keep this open for now though, I'd be interested in hearing if others feel the same way.

Answer 7 · 2016-08-30T22:06:42.000Z

If ready means bumping the version, the build script probably can be run in preversion.

Answer 8 · 2017-02-12T19:00:35.000Z

I'm going to keep as-is for now, it's been more convenient for me developing and the current .npmignore and cjs build scripts make a pretty flexible distribution.