Spec: Use Map instead of WeakMap

Question

Spec: Use Map instead of WeakMap

Jack-Works opened this issue 2 years ago · 4 comments

Jack-Works commented 2 years ago

since we're redesign this proposal, we can do it in the next rewrite

Answer 1 · 2023-09-05T14:22:27.000Z

Wait, why this change? We want things to be held weakly, no?

Answer 2 · 2023-09-05T16:08:21.000Z

Am I correct to guess the difference would become observable only if yielding within a match?

Answer 3 · 2023-09-06T06:46:49.000Z

Wait, why this change? We want things to be held weakly, no?

It was the decision made from the previous discussion. It is also not observable (Map or WeakMap) anyway, because it's impossible (if we don't have a bug in the spec) to leak the cache object to the userland.

I cannot recall the reason why someone want Map not WeakMap, maybe it's related to GC stuff.

Answer 4 · 2023-09-06T06:51:24.000Z

Am I correct to guess the difference would become observable only if yielding within a match?

Oh, maybe it is observable I'm not sure, if await or yield happened inside a match, but in this case, I think it would be better to keep things strongly held, otherwise, the match might behave in a strange way.