tcd/dark-plus-syntax

Comments too dark

Closed this issue ยท 5 comments

The color of the comments are too dark in my opinion. Is there a chance that this could be reverted back to the same green color from the original theme?
Thanks a lot!
image

I also agree. It also wouldn't hurt to make the curly braces/brackets/etc. a few shades lighter as well. In the meantime, you can reset comments back to green in your user settings with

    "editor.tokenColorCustomizations": {
		"textMateRules": [
            {
                "scope": [
                    "comment",
                    "comment.line.double-slash.js",
                    "comment.block.html",
                    "comment.block.handlebars"
                ],
                "settings": {
                    "foreground": "#608b4e"
                }
            },
        ]
    },

Thank you. I'll try that

@urielzen This sent me on a journey this morning ๐Ÿ˜‚

Turns out that code has a neat little tool for inspecting tokens. That should make it a lot easier to tweak things.

https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#scope-inspector

Also, if you want to apply those changes only to the dark-plus-syntax theme you'll want to do something like below:

  "editor.tokenColorCustomizations": {
    "[dark-plus-syntax]": {  // <----- Apply changes only to this theme
      "comments": "#888888",
      "textMateRules": [
        {
        "scope": [
          "punctuation.separator.array.json",
          "meta.structure.dictionary.json",
          "punctuation.definition.array.begin.json",
          "punctuation.definition.array.end.json",
          "punctuation.separator",
        ],
        "settings": {
            "foreground": "#888888"
          }
        }
      ]
    }
  },

@seanwash those are great tips. Thanks a lot!

The comment is too dark for me too, but I would suggest that make the comment lighter by default (if most people thinks the comment is too dark).