tcd/dark-plus-syntax

0.0.151 Diff background remove issues

urielzen opened this issue · 8 comments

urielzen commented

0.0.151 removed the background color to Diff window.
I believe that without the background color it is harder to identify where the new changes are happening.

image

Compare with original
image

Also the scrolling bar does not show where the changes are happening anymore.
now:
image

before:
image

urielzen commented

bump

chrisgbaker commented

Definitely still an issue. It's caused me to pick a different theme until this is fixed, as it makes the diff tool very cumbersome, especially the lack of the sidebar.

chrisgbaker commented

In reading the docs, i believe this is an easy fix:
image
I believe this theme is specifying both, which may be messing this up now. Not sure if this is a new change to how VSCode applies themes.

urielzen commented

@chrisgbaker fortunately there is an option in vscode to install a previous version so you dont have to switch themes.

image

chrisgbaker commented

@urielzen thanks! I wasn’t sure if that would work or if it was due to a change in vscode, but I’ll try that tomorrow

tcd commented

Hey @urielzen and all,

Sorry I didn't see this earlier. I'll look into this asap, thank you for bringing it to my attention.
Will post progress back to this issue.

Thanks,
Clay

tcd commented

@urielzen @chrisgbaker y'all take a look at the highlighting in 0.0.154 and let me know if there are still any issues.

urielzen commented

Thanks, it works great with the latest version!

  • 🎉1