[1.16.5-1.0.0] Environmental biomes are not compatible with Better Mineshafts and other overhaul mods

[TelepathicGrunt]

A person was talking in YUNGNICKYOUNG's discord about how their world kept spawning vanilla mineshafts alongside Better Mineshafts's mineshafts even tho that mod is suppose to remove all vanilla mineshafts to do the replacement. After looking some more, Yung found out that the vanilla mineshafts were spawning only in Abnormals or Environmental biomes.

Upon hearing this, I had a feel I know what the issue was and sure enough, it's this
https://github.com/team-abnormals/environmental/blob/199697a0154b968cb80d54b5bb92c406755cda49/src/main/java/com/minecraftabnormals/environmental/core/other/EnvironmentalGeneration.java

Basically, BiomeLoadingEvent is for adding, removing, and manipulating other people's biomes or vanilla biomes. It is not meant to be used by a mod on their own biomes. Which doesn't make much sense as that mod can just put the stuff in their biome builders or biome json files instead. That would be the standardized way of doing it that is compatible with other mods. Currently, Better Mineshaft is using BiomeLoadingEvent to find what biomes have vanilla mineshafts, remove that vanilla structure, and add their own mineshaft to that biome. But since Environmental's biomes are completely empty at this point, Better Mineshaft fails for Environmental's biomes as Environmental adds the features and structures to their own biomes after Better Mineshaft's event is ran.

If you are dead set on using BiomeLoadingEvent still, consider splitting off the part that targets your own biomes into another BiomeLoadingEvent and give that maximum priority so that it runs first and makes sure that other mods won't be finding Environmental's biomes empty by the time their BiomeLoadingEvent runs.