teamniteo/handbook

Move from TravisCI to CircleCI

Closed this issue · 5 comments

zupo commented

The Story

Handbook documents: User story & Work process

As a Nitean,
I want my pull requests to pass/fail faster,
so that I can be more productive.

Problem

We currently use Travis CI to run tests. In teamniteo/pyramid-realworld-example-app#37 we found that CircleCI takes much less overall time to run all the test cases.

Proposal

Switch over to CircleCI.

Pitfalls

Don't see any.

Best practices (DoD)

  • Documentation is revised:
    e.g. help articles, handbook pages or technical docs.
  • Product users are informed. e.g. blog post describing a new major feature.
  • Test coverage is 100%.

Expectations (AC)

suryasr007 commented

@zupo @karantan
The Travis CI is failing for two files.
./2_Operations/user-stories.md: Issues
./2_Operations/work-process.md: Issues
https://travis-ci.com/niteoweb/handbook

After configuring the Circle CI, Even this is failing for the same files.
https://circleci.com/gh/niteoweb/handbook/6

Are these known failures? Am I missing something?

zupo commented

What are the errors? Can you fix them?

suryasr007 commented

The following links are returning 404 in both Travis and Circle CI
https://github.com/settings/replies
https://github.com/notifications

Why are we checking these links as these are accessible only after logging in?

suryasr007 commented

As I can see, All the GitHub links are whitelisted, We can append the above entries as well to the whitelist.

  • 👍1