teamniteo/pyramid_mixpanel

Bug in distinct_id_is_required?

Closed this issue · 1 comments

I think distinct_id_is_required has a bug but I'm not 100% sure. This https://github.com/niteoweb/pyramid_mixpanel/blob/master/pyramid_mixpanel/track.py#L30 should be if not self.user.distinct_id: because self is pyramid_mixpanel.track.MixpanelTrack object.

Screenshot:

Screenshot 2019-08-30 09 49 35

zupo commented

MixpanelTrack.user was removed a while ago and replaced by MixpanelTrack.distinct_id: a04a56b