cache service alias conflicts with Symfony's cache parameter in http cache mode
andrerom opened this issue · 7 comments
"cache" is also used by symfony*, so the cache alias in this Bundle should be changed to something in stash namespace to avoid conflicts.
see: 363eece#L1R30
Yep, i think that should be fixed, especially cause a lot of users use AppCache.
A fix for was merged in and will be in the very next release, which should be this week.
Ok, make sure it's not a 0.3 release, that is going to break stuff :)
Any possibility to do a release today with this? We need to do a release of our own tomorrow morning euro time.
@andrerom before you consider trying to put this in your release tomorrow you really should look over the change log for v0.4 of this bundle and v0.12 of Stash. Because we were going to break BC anyways I made a few changes on top of this one that will probably affect you guys.
https://github.com/tedivm/TedivmStashBundle/blob/master/CHANGELOG.md
https://github.com/tedivm/Stash/blob/master/CHANGELOG.md
I was planning on reaching out to you guys to notify you of this, and to also ask if there are any other changes you'd like to see that may break BC which we should put in this release.
If you really want this namespace issue resolved it may be better to take the existing 0.3 line and apply a tag to that specific change (v0.3.4-EZ or something that won't auto upgrade people) and let you pull down from that.
Only things I can think about is removing constructors from interfaces, they don't belong there, it's implementation detail. Other then that I saw the new getAllDrivers, so ideally you should deprecate getDrivers and introduce getAvailableDrivers to make the api clear.
And thanks for the heads up, I'll skip 0.4 until after release then, and consider back porting the change.
Besides this, I think this issue can be closed, thanks.
Thanks for the feedback-I've incorporated your feedback about the interfaces and drivers class so that will be in the next release.