tediousjs/tedious-connection-pool

Update memory-usage test to add validation.

tvrprasad opened this issue · 2 comments

tvrprasad commented

Expected Behavior

Test change only.

Current Behavior

Current test has a few issues:

  1. Converting from Bytes to KB, it uses 1000 in one place and 100 in the other, vs 1024.
  2. It's running global.gc() at the end. Looking at the test I believe the intent is to run it after each poolSize number of connection attempts.
  3. There is no validation at the end.

Steps to Reproduce (for bugs)

Reason For Request (for feature requests)

I was reading the code to come up to speed on the project and noticed a few things in test\memory-usage.js that I thought I could improve. I'm opening this issue to attach to the pull request I'll be sending.

Possible Solution

Background Details

Test enhancement.

Environment

  • Node.js Version: v6.2.1
  • Windows/Mac/Linux: Windows
tvrprasad commented

@ben-page Please take a look.

ben-page commented

I added notes to the PR.