1.0.5 release may be incompatible with tedious 5.x release
BrianLawton opened this issue · 1 comments
Current Behavior
While I'm aware maintenance of the connection pool library has fallen behind the activity in the main tedious library, for our purposes, all tedious releases through the 4.2.0 have been compatible with the 1.0.5 release of the connection pool. When I attempted to upgrade to the tedious 5.x release, 5.0.1 to be specific, the connection pool library is no longer able to acquire connections. My debugging shows the root cause to be in the recent changes in how tedious handles authentication, specifically in forming the configuration values. Through the tedious 4.2.0 release the connection pool is at least tolerable of these changes, however since the internal updates to the 5.x tedious branch, tedious itself is no longer tolerable of these inconsistencies leaving the connection pool functionality fatally broken.
Reason For Request (for feature requests)
Background Details
At the moment, this is not a showstopper for us as we can live for now with tedious 4.2.0 so I'm only filing this for others benefit and with hopes someone else has the capacity to take on the much needed upgrades required to bring the connection pool library into full tedious 5.x support.
Possible Solution
Upgrade the connection pool package to reflect the new authentication options as well as other changes available in latest versions of tedious.
Environment
- Node.js: v10.15.0
- Windows 10 Pro and Server 2016
- tedious 5.0.1
After some additional testing, we've narrowed things down to a regression in Tedious 5.0.0 itself. As such, I'm closing this ticket. You can reference tediousjs/tedious#856 for details.