CI fails when SQL Server 2022 CUs can't be dowloaded
arthurschreiber opened this issue · 5 comments
@dhensby Every now and then I see the warning Warning: Unable to download cumulative updates from tediousjs/setup-sqlserver@v2, and if that happens, builds on SQL Server 2022 fail because the TDS 8 feature is broken on an unpatched 2022 version.
Can you take a look into why downloading the updates fails sporadically?
This is the line where the error comes from: https://github.com/tediousjs/setup-sqlserver/blob/v2.1.0/src/utils.ts#L199
There's not much logging going on here, so it's hard to know exactly why this is happening.
It could be:
- We have a bad status code (ie: error response from the server)
- The regex for pulling out the install link is not working.
I'll add a PR to increase logging so we can see what is going on here.
Something I had thought about when first authoring the cumulative updates feature was using the CI cache to hold onto these update URLs to prevent having to repeatedly hit the website for them, but the caching is more for caching files and not arbitrary data (https://github.com/actions/toolkit/tree/main/packages/cache).
Yeah. It would be nice to cache all the installer files, but I guess that can easily bump into the 10GB actions cache limit.
Do the URLs change regularly, or could the action ship with some defaults, which could then be used as a fallback if the check doesn't work?