tektoncd/experimental

[trusted task] Verify task and pipeline when apply them

Closed this issue · 4 comments

Yongxuanzhang commented

Right now we verify task and pipeline in taskrun and pipelinerun, it would be better if we can verify them when applying these resources. This can help users check if the resources they apply are valid. And also for each UPDATE it can also help to verify the resources.

austinzhao-go commented

Hi @Yongxuanzhang, thanks for the session about more details of the implementation requirements.
perhaps feel free to leave some bulletpoints you think important and I need to include into the work.

target to get the draft PR up in later this week or beginning of next week.

Yongxuanzhang commented

Yep! The key points of this issue is to understand the code in
https://github.com/tektoncd/experimental/blob/main/pipeline/trusted-resources/pkg/trustedtask/trustedtaskrun.go
https://github.com/tektoncd/experimental/blob/main/pipeline/trusted-resources/pkg/trustedtask/trustedpipelinerun.go
In these two files we verify the task and pipeline from taskrun and pipelinerun.

This issue want to have 2 similar files: trustedtask.go and trustedpipeline.go
and then create TrustedTask and TrustedPipeline, to do similar work for verification.

  • 👍1
austinzhao-go commented

merged impls for Task and Pipeline verification.

here related PRs
#886
#888

thanks @Yongxuanzhang's guidance on this work. closed this issue at this moment.

  • 👍1