chan_ack should not set seq value

Question

chan_ack should not set seq value

Closed this issue 10 years ago · 2 comments

https://github.com/telehash/telehash-c/blob/master/lib/chan.c#L295

The call to chan_seq_ack returns a packet with a seq value in it.

According to the spec, the bare ack should not have a seq, which will allow it to be filtered out from chan_pop delivery.

Answer 1 · 2014-05-14T13:45:29.000Z

Yes, definitely a bug :)

Answer 2 · 2014-05-17T14:44:52.000Z

There's been a decent amount of refactoring as I try to map a socket interface atop channels so it could still be a bit unstable, but hopefully it's a net-win here soon :)