tellnes/bunyan-middleware

Reason for seeing "request socket closed" warnings?

Closed this issue · 8 comments

AndrewLane commented

Hello, we are seeing "request socket closed" warnings coming from

bunyan-middleware/index.js

Line 128 in cea8b31

, 'request socket closed'

However, I am ignorant as to what I'm doing wrong to create that scenario. Anything simple or obvious?

msmol commented

I am seeing these warnings as well

Node: 10.2.1
express: 4.16.3
bunyan-middleware: 0.8.0

msmol commented

Downgrading to Node 8.9.4 seems to disappear the warning. I will continue to investigate

msmol commented

nodejs/node#21063

Is the root cause

ksmithut commented

So if that's the correct behavior for the 'close' event to be emitted always, perhaps this log shouldn't be a warn? or is it also indicative of warn behavior?

msmol commented

@ksmithut In my opinion it should no longer be logged at all, as a warn or otherwise, since it is now a "normal" event that isn't indicative of any problem or out-of-the-ordinary situation. See: https://github.com/tellnes/bunyan-middleware/pull/22/files

  • 👍3
ksmithut commented

@msmol I would agree, I should have looked at the existing PRs 👍

msmol commented

I opened that PR 2 weeks ago now, and no sign of any activity from the project owner 🤔

  • 👍2
tellnes commented

Merged the pull request, so closing this.