Restart Could Cause Disputes on Good Values Under Certain Conditions
Closed this issue · 1 comments
Observed behavior:
A good Value submitted 3 hours prior to a DVM restart triggered an alert (see image attached):
On restart, the DVM looks back in time a bit to gather recent reports. This can cause false positives because it's checking old values against the fresh price pulled from the APIs for that feed. The DVM was restarted when FIL was above $11 and an alert was sent for the value of $9.9 that was submitted hours ago, even though it was correct.
The report that caused the alert: https://etherscan.io/tx/0x58efed6ee569b5781a7b61f1a98368387b4e18fc6d124c18bf15ed03c66b3602
suggested fix:
This is more serious if the price change had been great enough to cause an automatic dispute. For example, if instead of 10% the price had shot up 200% and the DVM was configured to automatically dispute that queryId it would have been auto-disputed. (these kinds of price moves are very possible for crypto assets)
Suggest adding a check so that reports that are older than 5-10 minutes cannot be auto-disputed (alerts are still ok, so not suggesting any changes there.)
Let me know if more info is needed, and looking forward to more comments / ideas on how to best address this one. 🙏
resolved