github-tools seems to be picking the wrong property to query for GH URL.
tildebyte opened this issue · 1 comments
Latest ST3 beta, sublime-text-2-github-tools HEAD, on Win 7 x64
$ git branch
Textures
* master
$ git config branch.master.remote
origin
$ git config remote.master.url
$ git config remote.origin.url
https://tildebyte@github.com/tildebyte/processing.py.git
github-tools is using the remote.master.url
property (where master
is the branch) to determine the repo URL, rather than the remote.origin.url
property (where origin
is the repo).
The issue seems to be here: remote_alias
still refers to the branch, where it seems as though it should "pivot" to the repo url.
I think it would be somewhat invasive for me to code a solution, so I'd rather leave it to you.
Hey, sorry for not getting back to you. I don’t actively use Sublime Text these days, and have been quite busy on my daily job.
Looking at this, I don’t see how remote_alias
can refer to the branch when it is explicitly assigned the remote name, maybe I’m missing something. Although logically, if that was true, the plugin wouldn’t work for anybody, except for those whose branch names always match their remote names (which isn’t realistic). Given nobody else reported this, it means that it’s somehow unique to your setup (or nobody cares 😃). If you want to pursue this, please describe how this affects the functionality of the plugin (i.e. what are the visible outcomes of this).
I also cloned the jdf/processing.py repo and verified that the plugin works fine on my machine (latest stable ST3, latest stable OS X).
I’m going to close this issue for now, but feel free to re-open it. Also, please don’t hesitate to send pull requests if you know how to code a fix. I won’t think you’re being invasive. Thanks for your report!