tendermint/abci

Given a global flag to configure the application listen address, why non-global flags needed?

Closed this issue · 3 comments

maxim-levy commented

There is a global flag for the address defined as:

RootCmd.PersistentFlags().StringVarP(&flagAddress, "address", "", "tcp://0.0.0.0:46658", "address of application socket")

Then, what is the meaning for command-specific addr flags, like this one:

abci/cmd/abci-cli/abci-cli.go

Line 138 in 78a8905

kvstoreCmd.PersistentFlags().StringVarP(&flagAddrD, "addr", "", "tcp://0.0.0.0:46658", "listen address")

ebuchman commented

Seems like a redundancy - there should just be the global address.

Would you be interested in making a PR to clean this up ?

maxim-levy commented

Let me try to

  • 👍1
zramsay commented

merged to develop