tendermint/abci

Change absent validator representation to public keys instead of indices

cwgoes opened this issue · 3 comments

If absent validators are passed back as indices into a lexicographically sorted address array, ABCI applications must continually store/update such an array, which in most cases they would probably not otherwise need to do. Instead pass back absent validators by public key, as in abci.Evidence already. This adds a bit of extra communication overhead, but not too much and it only happens once per block.

This will be a breaking change for anyone using RequestBeginBlock.AbsentValidators.

Pubkeys or addresses?

Already changed to bytes on develop, but technically could still be either pubkey or address!

Ah sorry, I was looking at master, bytes is perfect.

tagging #231