tendermint/budget

fix: use panic instead of silently ignoring errors

hallazzang opened this issue · 0 comments

When an error occurs, we should panic if the error is significant or rarely occurs, to prevent silently ignoring important errors.

Some of examples are:

budgetSourceAcc, err := sdk.AccAddressFromBech32(budgetSource)
if err != nil {
continue
}

collectionAcc, err := sdk.AccAddressFromBech32(budget.CollectionAddress)
if err != nil {
continue
}

if err := k.bankKeeper.InputOutputCoins(ctx, inputs, outputs); err != nil {
continue
}